Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back Button on Map Load screen #4886

Closed
yuuiko opened this issue Jun 1, 2019 · 8 comments · Fixed by #5149
Closed

Back Button on Map Load screen #4886

yuuiko opened this issue Jun 1, 2019 · 8 comments · Fixed by #5149

Comments

@yuuiko
Copy link

yuuiko commented Jun 1, 2019

Describe the new feature:
Right now it's especially annoying if I accidentally start a map and i'd need to wait for it to load in order to go to song select.

Edit: The context is mobile.

Proposal designs of the feature:
IMG_5489

@LeNitrous
Copy link
Contributor

But you can hit escape to cancel loading? Pretty sure it should be the same for stable.

@jai-x
Copy link
Member

jai-x commented Jun 1, 2019

On mobile where it's touchscreen only, you would not be able to press the escape button. I agree that we would need a back button to cancel loading.

@LeNitrous
Copy link
Contributor

Might as well be a good QoL button since in my case for Android, my OS blocks navigational input like home and back buttons when in games.

@peppy
Copy link
Member

peppy commented Jun 3, 2019

The back button needs to be moved to a global level element.

@peppy peppy added this to the July 2019 milestone Jun 3, 2019
@yuuiko
Copy link
Author

yuuiko commented Jun 3, 2019

back button should appear on the multi lobby too.

Side note: Are you sure multi should be an overlay? It’s kind of jarring to use because its not consistent with the full page layout of singleplayer song select and editor...

@peppy
Copy link
Member

peppy commented Jun 3, 2019

It was designed as an overlay so one could browse games while still using other elements, such as solo or edit. This has yet to be fully realised, but for the time being the design remains as such.

@yuuiko
Copy link
Author

yuuiko commented Jun 3, 2019

Thing is, this would be the case if it was in the top bar, but its not and instead is treated like a game mode (solo, edit) in the main menu.

Plus, I don’t think that people would have the need to get into multiplayer while editing or playing solo, so thats a bit questionable to me.

Current design is understandable from your comment, but i’d advise to reconsider. If you want to keep as is, add a multi button to the top menu, but as the design is not final and you may have plans I’m not aware about, I’ll see what happens in the end.

@peppy
Copy link
Member

peppy commented Jun 3, 2019

It was intended to be in a global bar. As I said, this is not yet raelised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants