Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods instantly pop up after switching gameplay modes #3863

Open
naoei opened this issue Dec 16, 2018 · 3 comments
Open

Mods instantly pop up after switching gameplay modes #3863

naoei opened this issue Dec 16, 2018 · 3 comments

Comments

@naoei
Copy link
Contributor

naoei commented Dec 16, 2018

It would be nice to have them animating instead of just popping up (like in this example)
Video

Maybe add a rotating and/or scaling up animation, and for the one that arent available, maybe add a fade for them.
I might make a PR for this feature, but im not sure

@peppy
Copy link
Member

peppy commented Dec 17, 2018

Yeah. There’s a reason this hasn’t been fixed yet (due to the structure of the mods overlay making it a bit hard to do such animtions). I tried to fix in #3340 but decided it was more effort than I was willing to put in in the short term.

@naoei
Copy link
Contributor Author

naoei commented Dec 17, 2018

yeah, I've tried adding animation to it but no luck what so ever.
but I'll try to make a pr for this as soon as I can. I also heard that there is some kind of "code quality" thing going on, can you share me the rules for it so that the code doesn't look any different from the rest?

@peppy
Copy link
Member

peppy commented Dec 17, 2018

You can run the build script to check for code formatting. Alternatively if you have resharper/rider it will do this for you in real-time.

@smoogipoo smoogipoo added this to the Backlog milestone Jan 7, 2019
@peppy peppy added the priority:3 Nice to have, at some point label Feb 17, 2020
@peppy peppy removed this from the Backlog milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants