osu!taiko is not benefitting from pooling

[peppy]

Every usage of DrawableTaikoHitObject recreates its drawable hierarchy in OnApply, rather than pooling per type (all combinations of centre/rim strong/normal).

osu/osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs

Lines 133 to 147 in a215d00

	protected override void OnApply()
	{
	base.OnApply();
	RecreatePieces();
	}
	protected virtual void RecreatePieces()
	{
	Size = BaseSize = new Vector2(TaikoHitObject.DEFAULT_SIZE);
	if (MainPiece != null)
	Content.Remove(MainPiece, true);
	Content.Add(MainPiece = CreateMainPiece());
	}

[bdach]

The reason this particular flow was originally done is for editor purposes, to support changing hit colour. Making this work as described (each colour pooled separately) likely requires extra work on pooling in editor as to me there is no known precedent for essentially changing the type of pooled drawable used.

[peppy]

osu/osu.Game.Rulesets.Taiko/UI/TaikoPlayfield.cs

Lines 346 to 347 in a2f8ff8

	if (drawableObject.HitObject.Kiai)
	kiaiExplosionContainer.Add(new KiaiHitExplosion(drawableObject, type));

This is also another WTF.