Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit circles can appear partially off-screen in certain resolutions with barrel roll mod #13683

Open
aitani9 opened this issue Jun 28, 2021 · 2 comments
Labels
area:mods priority:2 Moderately important. Relied on by some users or impeding the usability of the game ruleset/osu!

Comments

@aitani9
Copy link
Contributor

aitani9 commented Jun 28, 2021

Describe the bug: Seems to only be a problem for hit circles placed near a corner of the playfield.

Screenshots or videos showing encountered issue:

example.mp4

Beatmap in video: 7 star map of Chasers - Lost (ktgster).zip

osu!lazer version: commit a9084db

@frenzibyte frenzibyte added area:mods ruleset/osu! priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Jun 28, 2021
@EVAST9919
Copy link
Contributor

Resolution doesn't really matter: as long as lazer window is in landscape mode - it will happen.
Potential solution is to use playfield diagonal length instead of max side length here

var playfieldSize = drawableRuleset.Playfield.DrawSize;
var minSide = MathF.Min(playfieldSize.X, playfieldSize.Y);
var maxSide = MathF.Max(playfieldSize.X, playfieldSize.Y);
drawableRuleset.Playfield.Scale = new Vector2(minSide / maxSide);

But I'm not sure since playfield will become even smaller:

master proposed solution
osu_2021-06-30_01-07-44 osu_2021-06-30_01-09-59
osu_2021-06-30_01-08-01 osu_2021-06-30_01-10-06

@EVAST9919
Copy link
Contributor

Another solution is to add virtual margin value, so it can be configurable per ruleset.
So here we can just add this value to the maxSide.

var maxSide = MathF.Max(playfieldSize.X, playfieldSize.Y);

For example, for osu it will be the circle size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:mods priority:2 Moderately important. Relied on by some users or impeding the usability of the game ruleset/osu!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants