Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest mappers are not shown correctly on multiple places in the game #12965

Open
LeNitrous opened this issue May 26, 2021 · 2 comments
Open

Guest mappers are not shown correctly on multiple places in the game #12965

LeNitrous opened this issue May 26, 2021 · 2 comments
Labels
area:results area:song-select priority:1 Very important. Feels bad without fix. Affects the majority of users. realm deals with local realm database

Comments

@LeNitrous
Copy link
Contributor

LeNitrous commented May 26, 2021

Describe the bug: The beatmap info wedge map author when clicked sends you to the wrong profile.

This is due to recent API changes that affected BeatmapMetadata which is done in this pull request: ppy/osu-web#7517. The user_id property now uses the difficulty owner set via beatmap discussions but the creator property still uses the beatmap set host.

A suggestion which may be worthwhile is instead of showing mapped by <creator>, it should instead show hosted by <host> and mapped by <creator>. However, the API endpoint responsible for fetching the beatmap metadata only returns the difficulty owner's ID and requires another lookup in the API.

To reproduce:

  • In beatmap discussions, change the most bottom-most (most difficult) difficulty owner to anyone else
    image

  • If the beatmap already exists in lazer, delete it and restart the game.

  • Download the beatmap via the web, in-game, or import via stable.

I'll attempt at fixing this if I can be assigned in this issue.

Screenshots or videos showing encountered issue:
ymk4jfaKjo

osu!lazer version: master

Logs: N/A

@peppy
Copy link
Member

peppy commented May 26, 2021

This is wrong in multiple places, so keep that in mind when looking into a fix (needs to be fixed in the local lookup too).

@peppy peppy added realm deals with local realm database priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels May 26, 2021
@frenzibyte frenzibyte changed the title Beatmap Info Wedge Map Author Link is Incorrect Beatmap author link is incorrect in beatmap info wedge Jul 10, 2021
@Joehuu Joehuu assigned Joehuu and unassigned Joehuu Aug 19, 2023
@frenzibyte frenzibyte changed the title Beatmap author link is incorrect in beatmap info wedge Guest mappers are not shown correctly on multiple places in the game Dec 17, 2024
@frenzibyte frenzibyte added area:results priority:1 Very important. Feels bad without fix. Affects the majority of users. and removed priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Dec 17, 2024
@frenzibyte
Copy link
Member

Seeing various reports on this across the years, I think it's good to prioritise it. Shouldn't take much effort anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:results area:song-select priority:1 Very important. Feels bad without fix. Affects the majority of users. realm deals with local realm database
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants