Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed mods are not stable-ordered #12672

Open
Ecpii opened this issue May 3, 2021 · 3 comments
Open

Displayed mods are not stable-ordered #12672

Ecpii opened this issue May 3, 2021 · 3 comments
Labels
area:multiplayer area:overlay-mod-select priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic

Comments

@Ecpii
Copy link

Ecpii commented May 3, 2021

Describe the bug:
Using Double Time in multi and allowing free mods can give submitted scores incorrect mod orders (Hidden appears before Double Time in the mod display). Haven't tested with other mod combinations, but it seems to be an issue with using free mods in multi.

Screenshots or videos showing encountered issue:
image

osu!lazer version: 2021.502.0

Logs:
logs.zip

@peppy
Copy link
Member

peppy commented May 4, 2021

What's the expected ordering here? The order in which mods appear in the mod overlay?

@Ecpii
Copy link
Author

Ecpii commented May 4, 2021

I initially expected the mods to be ordered in the same way that a solo score submission would order them (order of the mod overlay, DTHD), but then I realized that it's inconsistent with the mod order on the website (HDDT) as well as the mod order in stable (which also turns out to be slightly different from the website). I think it would be best to have lazer match the website, since they are very similar in design.

@peppy peppy changed the title Using freemod in multi can give scores incorrect mod orders Displayed mods are not stable-ordered May 6, 2021
@peppy
Copy link
Member

peppy commented May 6, 2021

I think this should be the responsibility of the client (in the ModDisplay component) to enforce some kind of stable ordering.

@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:multiplayer area:overlay-mod-select priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic
Projects
None yet
Development

No branches or pull requests

3 participants