Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image display support to changelog #12465

Open
lilyremigia opened this issue Apr 17, 2021 · 3 comments
Open

Add image display support to changelog #12465

lilyremigia opened this issue Apr 17, 2021 · 3 comments
Labels
area:overlay-changelog osu!framework issue Can't resolve this without changes to osu!framework. priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic

Comments

@lilyremigia
Copy link

Describe the new feature: Show images in the changelog in-game, just like on the web.
@peppy
Copy link
Member

peppy commented Apr 23, 2021

This relies on using the markdown parser, but this currently doesn't have image support. Likely going to start as a framework change as that's where this lives right now.

@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label Apr 23, 2021
@peppy peppy changed the title Load & Show images in changelogs Add image display support to changelog Apr 23, 2021
@peppy peppy added the osu!framework issue Can't resolve this without changes to osu!framework. label Apr 23, 2021
@smoogipoo
Copy link
Contributor

smoogipoo commented Apr 23, 2021 •
edited
Loading

The markdown parser / MarkdownContainer does have image support. No gif support though.

@peppy
Copy link
Member

peppy commented Apr 23, 2021

I guess we could try actually using that, and limit changelog entries to only contain jpg/png for the time being.

@jai-x jai-x mentioned this issue Nov 27, 2021
Closed
@Joehuu Joehuu mentioned this issue Aug 31, 2022
Closed
@frenzibyte frenzibyte mentioned this issue Nov 25, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:overlay-changelog osu!framework issue Can't resolve this without changes to osu!framework. priority:2 Moderately important. Relied on by some users or impeding the usability of the game type:cosmetic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@peppy @smoogipoo @lilyremigia @bdach