Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to beatmap" button inserts the beatmap set into the currently selected collection #11325

Open
rederick29 opened this issue Dec 26, 2020 · 4 comments

Comments

@rederick29
Copy link

Describe the bug: Selecting a collection in the song select menu and then clicking the "go to beatmap" button in osu!direct on a map that is not in the collection makes the map appear in the collection. This does not add the map to the collection but only shows is as being in it.

Screenshots or videos showing encountered issue:

osu!lazer version: 2020.1225.0

Logs:

runtime.log
performance.log

@LittleEndu
Copy link
Contributor

Pretty sure this is indented. Go to beatmap ignores all filters song select has

@bdach
Copy link
Collaborator

bdach commented Dec 26, 2020

Yeah, that's how it will work, as presenting a beatmap will bypass filters, but it perhaps is not the most understandable UX...

@rederick29
Copy link
Author

If it is intended, then it is misleading in my opinion, as it can make people think that the beatmap set was added to their collection.
Proposal: If the beatmap set is not in the currently selected collection, then the song select menu should change filtering to "All beatmaps" and then show the map when the "Go to beatmap" button is clicked.

@peppy
Copy link
Member

peppy commented Dec 27, 2020

It is impletmented the way it is to avoid losing the user's filter.

If it's going to change to "all beatmaps" then there needs to be a way to restore previous filter settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants