Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal]Able to add the localization to all matched localization class. #54

Open
andy840119 opened this issue Jun 7, 2022 · 2 comments

Comments

@andy840119
Copy link

andy840119 commented Jun 7, 2022

Another request beside #53 is able to select and add the localization string to those matched localization class.
image
Will have more option like Like Insert the localization to the Chat/AAAStrings.cs and Insert the localization to the Chat/BBBStrings.cs

The proposal is figured out while implementing this issue.
karaoke-dev/karaoke#1365

It should be able merge into just two localization class named GeneratorStrings and DetectorStrings.
It will let the translation easy to be added if user can selected exist matched localization classes in the Localisation.

@smoogipoo
Copy link
Collaborator

I don't agree with adding more options. Two is the max I'd want to display, any more than that will result in mental overload. Even two options is already feeling like too much.

@andy840119
Copy link
Author

Okay, i think the only remain option to collect the localization is following the discussion in here:
karaoke-dev/karaoke#1265 (comment)

Or created to the CommonStrings.cs, then move it by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants