Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TabItem.IsRemovable default to true #2425

Merged
merged 2 commits into from
May 21, 2019
Merged

Change TabItem.IsRemovable default to true #2425

merged 2 commits into from
May 21, 2019

Conversation

peppy
Copy link
Member

@peppy peppy commented May 21, 2019

The previous default value felt unintuitive. This is a minor breaking change.

Also throw an exception when trying to remove a tab that should not be removed.

@peppy peppy added the area:UI label May 21, 2019
@smoogipoo smoogipoo merged commit 0dfaebe into ppy:master May 21, 2019
@peppy peppy deleted the change-tabitem-isremovable branch May 31, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @smoogipoo