Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFlowContainer should wrap on individual characters as a last resort #5007

Open
smoogipoo opened this issue Jan 31, 2022 · 5 comments
Open
Labels
area:drawable priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@smoogipoo
Copy link
Contributor

smoogipoo commented Jan 31, 2022

In order to not overflow the parenting container, TextFlowContainer should be able to resort to wrapping on an individual character basis. This will need additional consideration for e.g. links (ppy/osu#10085).

@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Jan 31, 2022
@bdach
Copy link
Collaborator

bdach commented Jan 31, 2022

Semi-related: ppy/osu#14837

@baharsah

This comment was marked as off-topic.

@bdach
Copy link
Collaborator

bdach commented Feb 16, 2022

@baharsah the issue you describe above is unrelated. the component in lazer shown on the screenshot is not even using text flow right now.

@Spooghetti420
Copy link

Spooghetti420 commented Sep 4, 2022

How does the TextFlowContainer decide where a line break should go? Is it some part of computeLayout? I noticed this also affects multiplayer chatrooms, e.g. if a long, unbroken row of characters is sent, it overflows that chat boundary as well.
osu_2022-09-04_21-05-46
I was about to post an issue on the main osu! repo, but I just about stumbled into this issue. Would it make sense to do that, so that others are aware it's a known bug?

@bdach
Copy link
Collaborator

bdach commented Sep 4, 2022

How does the TextFlowContainer decide where a line break should go? Is it some part of computeLayout? I noticed this also affects multiplayer chatrooms, e.g. if a long, unbroken row of characters is sent, it overflows that chat boundary as well.

See TextChunk.SplitWords() for the answer to that.

I was about to post an issue on the main osu! repo, but I just about stumbled into this issue. Would it make sense to do that, so that others are aware it's a known bug?

It would not make much sense as it's the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:drawable priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Development

No branches or pull requests

5 participants