You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web-sdk alpha release branch is getting really out of sync with main, getting the change in folder structure in will reduce the overhead of changes made that are independent of anything related to web.
Work Done
Included folder structure changes found in alpha-release branch
How to test
Review any recent changes and confirm they are included in this
As the person who made the initial folder structure changes I am happy with these changes 😁 , that being said I would defer the final approval to @rkistner in order to have a different set of eyes on it.
It's not listed in the PR description, but I'm assuming the alpha-release branch has been updated with master before these changes were extracted from it? This PR only contains 2 commits, which makes it difficult to verify it's up to date without going through the code line-by-line.
@stevensJourney I have not updated alpha-release branch yet as I wanted to do this in steps to avoid overwriting things unintentionally. I collated the changes though between the master and alpha-release branches by seeing going through the diff and so all of Ralf's changes should be in here with the folder structure changes you made in alpha-release.
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the changes here.
Just note that some of these are breaking changes, for example DefaultSqliteOpenFactory.open() changing to return a future, so any future release will have to bump the version to at least 0.7.0.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The web-sdk alpha release branch is getting really out of sync with main, getting the change in folder structure in will reduce the overhead of changes made that are independent of anything related to web.
Work Done
How to test