Update from upstream #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit dfaff6a Author: The one with the braid <info@braid.business> Date: Thu Aug 8 13:53:05 2024 +0200 chore: update Gradle configuration - match minimum SDK version to Flutter's minimum - migrate compileSdkVersion to compileSdk - update compileSdk to Flutter's target Signed-off-by: The one with the braid <info@braid.business>
davidmartos96
force-pushed
the
update_from_upstream
branch
from
f54e3cb to
661eb26
Compare
rkistner
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the fork with upstream
sqlite3from pub v2.4.6, which supportsweb1.0.0To better see the actual changes with this we can see the diff between upstream and the fork with this PR and with the latest published version.
This PR vs upstream 2.4.6
git diff 0f466963aaf654a176aa7e48352d7016db0db9e7..661eb26571725aa7504624f2290eb818343cc31b(change
661ebwith latest commit in this PR if more commits are pushed)Fork
v2.4.5-powersync.0.3.0vs upstream 2.4.5git diff c028b09a3048f3ed971f08e2905f970af4c48784..6fbd49b50aba272079c587ff9cf513d20890c85fQuestions
Is there any particular reason why the publish WASM was built against SQLite version 3.44 instead of 3.46? I used 3.46 in this PR (CMakeLists.txt) and it seems that both the build and
powersync_init()work fine.