chore(attachments): minor improvements and fix loop #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
reviewed
Apr 8, 2024
| @@ -33,14 +33,18 @@ abstract class AbstractAttachmentQueue { | |||
| /// Return true if you want to ignore attachment | |||
| Future<bool> Function(Attachment attachment, Object exception)? onUploadError; | |||
|
|
|||
| /// Interval in minutes to periodically delete archived attachments | |||
There was a problem hiding this comment.
Comments says this is for deleting archived attachments, but the timer also calls runSync() on the same interval. What effect does that have?
There was a problem hiding this comment.
Sorry I missed changing this comment. This sets the timer for startPeriodicSync which deletesArchived attachments and runs a sync again in case one of the attachments which was archived is now available to download.
rkistner
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor improvements based on feedack
Work Done
executeBatchdelete