Skip to content

Add missing xcframework properties #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Add missing xcframework properties #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
743feaf
Add MinimumOSVersion=11.0
rkistner Jan 29, 2024
828d27d
Add more required properties.
rkistner Jan 30, 2024
fb73541
Update repo URL.
rkistner Jan 30, 2024
da8707f
Update the release instructions.
rkistner Jan 30, 2024
6b150ed
Update another repo reference.
rkistner Jan 30, 2024
565d30d
And another one.
rkistner Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ authors = ["JourneyApps"]
keywords = ["sqlite", "powersync"]
license = "Apache-2.0"
homepage = "https://powersync.co"
repository = "https://github.com/journeyapps/powersync-sqlite-core"
repository = "https://github.com/powersync-ja/powersync-sqlite-core"

[workspace.dependencies]
sqlite_nostd = { path="./sqlite-rs-embedded/sqlite_nostd" }
11 changes: 9 additions & 2 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Bump the version number in these places:
1. Cargo.toml
2. powersync-sqlite-core.podspec.
3. android/build.gradle.kts
4. build-pod.sh - CFBundleVersion and CFBundleShortVersionString.
5. `cargo build` to update Cargo.lock

Create a tag:

Expand All @@ -25,8 +27,7 @@ The above does the following:

1. Create a draft GitHub release.
2. Build the xcframework for iOS and macOS, and upload to GitHub (attached to the above release).
3. Publish the cocoapod for iOS and macOS.
4. Build and publish an Android aar to Sonatype staging.
3. Build and publish an Android aar to Sonatype staging.

Once that is done, go to the Maven staging repository, and "Close", wait, and "Release" the
repository:
Expand All @@ -36,3 +37,9 @@ https://s01.oss.sonatype.org/#stagingRepositories
Docs: https://central.sonatype.org/publish/release/

Go to GitHub Releases on the repository, update the description, then "Publish Release".

Publish the cocoapod:

```sh
pod trunk push powersync-sqlite-core.podspec
```
10 changes: 5 additions & 5 deletions android/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ publishing {
pom {
name.set(project.name)
description.set(project.description)
url.set("https://github.com/journeyapps/powersync-sqlite-core")
url.set("https://github.com/powersync-ja/powersync-sqlite-core")

developers {
developer {
Expand All @@ -102,9 +102,9 @@ publishing {
}

scm {
connection.set("scm:git:github.com/journeyapps/powersync-sqlite-core.git")
developerConnection.set("scm:git:ssh://github.com/journeyapps/powersync-sqlite-core.git")
url.set("https://github.com/journeyapps/powersync-sqlite-core")
connection.set("scm:git:github.com/powersync-ja/powersync-sqlite-core.git")
developerConnection.set("scm:git:ssh://github.com/powersync-ja/powersync-sqlite-core.git")
url.set("https://github.com/powersync-ja/powersync-sqlite-core")
}
}
}
Expand All @@ -125,7 +125,7 @@ publishing {
if (System.getenv("GITHUB_ACTOR") != null) {
maven {
name = "GitHubPackages"
url = uri("https://maven.pkg.github.com/journeyapps/powersync-sqlite-core")
url = uri("https://maven.pkg.github.com/powersync-ja/powersync-sqlite-core")
credentials {
username = System.getenv("GITHUB_ACTOR")
password = System.getenv("GITHUB_TOKEN")
Expand Down
6 changes: 6 additions & 0 deletions build-pod.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ function createXcframework() {
<string>FMWK</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>MinimumOSVersion</key>
<string>11.0</string>
<key>CFBundleVersion</key>
<string>0.1.5</string>
<key>CFBundleShortVersionString</key>
<string>0.1.5</string>
</dict>
</plist>
EOF
Expand Down
4 changes: 2 additions & 2 deletions powersync-sqlite-core.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ Pod::Spec.new do |s|
PowerSync extension for SQLite.
DESC

s.homepage = 'https://github.com/journeyapps/powersync-sqlite-core'
s.homepage = 'https://github.com/powersync-ja/powersync-sqlite-core'
s.license = 'Apache License, Version 2.0'
s.author = 'Journey Mobile, Inc.'

s.source = { :http => "https://github.com/journeyapps/powersync-sqlite-core/releases/download/v#{s.version}/powersync-sqlite-core.xcframework.tar.xz" }
s.source = { :http => "https://github.com/powersync-ja/powersync-sqlite-core/releases/download/v#{s.version}/powersync-sqlite-core.xcframework.tar.xz" }
s.vendored_frameworks = 'powersync-sqlite-core.xcframework'


Expand Down