feat: add query builder package #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
reviewed
Feb 27, 2024
benitav
previously approved these changes
Feb 27, 2024
rkistner
previously approved these changes
Feb 27, 2024
rkistner
reviewed
Feb 27, 2024
packages/kysely-driver/README.md
Outdated
|
|
||
| ```js | ||
| await powerSyncDb.execute('INSERT INTO users (id, name) VALUES(3, ?)', ['Lucy']); | ||
| await powerSyncDb.execute("UPDATE users SET name = ? WHERE name = 'Lucy'", ['Lucy Smith']); |
There was a problem hiding this comment.
Please parameterize the WHERE name = ? bit as well, to make it more equivalent to the Kysely example.
packages/kysely-driver/README.md
Outdated
| ```js | ||
| await powerSyncDb.writeTransaction((transaction) => { | ||
| await transaction.execute('INSERT INTO users (id, name) VALUES(4, ?)', ['James']); | ||
| await transaction.execute("UPDATE users SET name = ? WHERE name = 'James'", ['James Smith']); |
stevensJourney
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add kysely-driver package to monorepo to allow for typed queries
Work done
Added new package