Improvements to code examples #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Apr 1, 2025
There was a problem hiding this comment.
This generally looks good to me 👍 Despite what I've said earlier offline, I think in this case it makes sense to consistently use relative imports though. The reason is that we don't know the package name the user wil choose for their app, and relative imports will "just work" as long as you put the snippets we suggest in the same folder.
simolus3
approved these changes
Apr 2, 2025
simolus3
approved these changes
Apr 2, 2025
joshua-journey-apps
pushed a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements to the code examples by