Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder Structure #656

Open
2 tasks done
moritztim opened this issue Jun 16, 2022 · 6 comments
Open
2 tasks done

Folder Structure #656

moritztim opened this issue Jun 16, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@moritztim
Copy link

Describe the bug
The folder structure seems unnecessarily complicated, Powercord/src/powercord/plugins is where the plugins are at for example, while the injectors are not even in the src dir

To Reproduce

  1. look at the repo

Expected behavior

  1. you get confused

Desktop (please complete the following information):

  • OS: any
  • Powercord version: 2.0.0

Additional context

  • I checked if Discord and/or Powercord are up to date
  • I made sure this is not related to an external plugin or a theme
@moritztim moritztim added the bug Something isn't working label Jun 16, 2022
@colin273
Copy link

This doesn't qualify as a bug. While it is a counterintuitive (or rather, questionable) design choice imo, it's not going to be changed anytime soon unless someone submits a PR to change the entire folder structure and the devs decide to accept it, considering that some plugins would break with a different folder structure.

As for the injectors, those are external scripts, while src/ is for the mod itself, the stuff that is loaded with Discord.

@moritztim
Copy link
Author

As for the injectors, those are external scripts, while src/ is for the mod itself, the stuff that is loaded with Discord.

they are still scripts tho, so they still have no right to be in root, one would probably have to have another subdir inside src for powercord in that case, which would technically make more sense but might be even more complicated for the user...

@asportnoy
Copy link
Contributor

asportnoy commented Jun 17, 2022

If it really bothers you, you can just create an alias/shortcut/symlink/whatever your OS equivalent is to the plugins directory and put it wherever you want.

@moritztim
Copy link
Author

ofc, I am not personally bothered by it, just thought it would be nicer to have it a bit clearer.

@moritztim
Copy link
Author

As for the injectors, those are external scripts, while src/ is for the mod itself, the stuff that is loaded with Discord.

they are still scripts tho, so they still have no right to be in root, one would probably have to have another subdir inside src for powercord in that case, which would technically make more sense but might be even more complicated for the user...

👎 - @FifiTheBulldog

My point is that this should be in the src dir cause it doesn't belong with things like the readme imo, tho that might further complicate it, so it's fine

@ToxicSmurf
Copy link

grass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants