Allow declaring long vector rawbuffer resources

Previously disallowed along with other global types, this provides a
mechanism for indicating which buffers are raw and allowing them to
contain long vectors, continuing to produce an error for other resource
types verified by existing tests

Author: Greg Roth

tools/clang/lib/Sema/SemaHLSL.cpp

@@ -344,6 +344,7 @@ enum ArBasicKind {
 #define BPROP_FEEDBACKTEXTURE                                                  \
   0x00800000                  // Whether the type is a feedback texture.
 #define BPROP_ENUM 0x01000000 // Whether the type is a enum
+#define BPROP_RAWBUFFER 0x02000000 // Whether the type is a raw buffer.
 
 #define GET_BPROP_PRIM_KIND(_Props)                                            \
   ((_Props) & (BPROP_BOOLEAN | BPROP_INTEGER | BPROP_FLOATING))
@@ -384,6 +385,7 @@ enum ArBasicKind {
   (IS_BPROP_AINT(_Props) && GET_BPROP_BITS(_Props) != BPROP_BITS12)
 
 #define IS_BPROP_ENUM(_Props) (((_Props)&BPROP_ENUM) != 0)
+#define IS_BPROP_RAWBUFFER(_Props) (((_Props)&BPROP_RAWBUFFER) != 0)
 
 const UINT g_uBasicKindProps[] = {
     BPROP_PRIMITIVE | BPROP_BOOLEAN | BPROP_INTEGER | BPROP_NUMERIC |
@@ -512,22 +514,30 @@ const UINT g_uBasicKindProps[] = {
     BPROP_OBJECT | BPROP_RWBUFFER | BPROP_TEXTURE, // AR_OBJECT_RWTEXTURE3D
     BPROP_OBJECT | BPROP_RWBUFFER,                 // AR_OBJECT_RWBUFFER
 
-    BPROP_OBJECT | BPROP_RBUFFER,  // AR_OBJECT_BYTEADDRESS_BUFFER
-    BPROP_OBJECT | BPROP_RWBUFFER, // AR_OBJECT_RWBYTEADDRESS_BUFFER
-    BPROP_OBJECT | BPROP_RBUFFER,  // AR_OBJECT_STRUCTURED_BUFFER
-    BPROP_OBJECT | BPROP_RWBUFFER, // AR_OBJECT_RWSTRUCTURED_BUFFER
-    BPROP_OBJECT | BPROP_RWBUFFER, // AR_OBJECT_RWSTRUCTURED_BUFFER_ALLOC
-    BPROP_OBJECT | BPROP_RWBUFFER, // AR_OBJECT_RWSTRUCTURED_BUFFER_CONSUME
-    BPROP_OBJECT | BPROP_RWBUFFER, // AR_OBJECT_APPEND_STRUCTURED_BUFFER
-    BPROP_OBJECT | BPROP_RWBUFFER, // AR_OBJECT_CONSUME_STRUCTURED_BUFFER
+    BPROP_OBJECT | BPROP_RBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_BYTEADDRESS_BUFFER
+    BPROP_OBJECT | BPROP_RWBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_RWBYTEADDRESS_BUFFER
+    BPROP_OBJECT | BPROP_RBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_STRUCTURED_BUFFER
+    BPROP_OBJECT | BPROP_RWBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_RWSTRUCTURED_BUFFER
+    BPROP_OBJECT | BPROP_RWBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_RWSTRUCTURED_BUFFER_ALLOC
+    BPROP_OBJECT | BPROP_RWBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_RWSTRUCTURED_BUFFER_CONSUME
+    BPROP_OBJECT | BPROP_RWBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_APPEND_STRUCTURED_BUFFER
+    BPROP_OBJECT | BPROP_RWBUFFER |
+        BPROP_RAWBUFFER, // AR_OBJECT_CONSUME_STRUCTURED_BUFFER
 
     BPROP_OBJECT | BPROP_RBUFFER, // AR_OBJECT_CONSTANT_BUFFER
     BPROP_OBJECT | BPROP_RBUFFER, // AR_OBJECT_TEXTURE_BUFFER
 
     BPROP_OBJECT | BPROP_RWBUFFER | BPROP_ROVBUFFER, // AR_OBJECT_ROVBUFFER
-    BPROP_OBJECT | BPROP_RWBUFFER |
+    BPROP_OBJECT | BPROP_RWBUFFER | BPROP_RAWBUFFER |
         BPROP_ROVBUFFER, // AR_OBJECT_ROVBYTEADDRESS_BUFFER
-    BPROP_OBJECT | BPROP_RWBUFFER |
+    BPROP_OBJECT | BPROP_RWBUFFER | BPROP_RAWBUFFER |
         BPROP_ROVBUFFER, // AR_OBJECT_ROVSTRUCTURED_BUFFER
     BPROP_OBJECT | BPROP_RWBUFFER | BPROP_ROVBUFFER, // AR_OBJECT_ROVTEXTURE1D
     BPROP_OBJECT | BPROP_RWBUFFER |
@@ -641,6 +651,8 @@ C_ASSERT(ARRAYSIZE(g_uBasicKindProps) == AR_BASIC_MAXIMUM_COUNT);
 
 #define IS_BASIC_ENUM(_Kind) IS_BPROP_ENUM(GetBasicKindProps(_Kind))
 
+#define IS_BASIC_RAWBUFFER(_Kind) IS_BPROP_RAWBUFFER(GetBasicKindProps(_Kind))
+
 #define BITWISE_ENUM_OPS(_Type)                                                \
   inline _Type operator|(_Type F1, _Type F2) {                                 \
     return (_Type)((UINT)F1 | (UINT)F2);                                       \
@@ -15071,7 +15083,8 @@ bool Sema::DiagnoseHLSLDecl(Declarator &D, DeclContext *DC, Expr *BitWidth,
   }
 
   // Disallow long vecs from $Global cbuffers.
-  if (isGlobal && !isStatic && !isGroupShared) {
+  if (isGlobal && !isStatic && !isGroupShared &&
+      !IS_BASIC_RAWBUFFER(basicKind)) {
     // Suppress actual emitting of errors for incompletable types here
     // They are redundant to those produced in ActOnUninitializedDecl.
     struct SilentDiagnoser : public TypeDiagnoser {