Update Symfony packages to version 5 #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
| @@ -14,8 +14,8 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^7.1", | |||
| "symfony/console": "^4.0", | |||
| "symfony/finder": "^4.0", | |||
| "symfony/console": "^4.0 || ^5.0", | |||
There was a problem hiding this comment.
How come your using the || operator here? Cant we just update it to 5.0 and then bump up the major release version?
There was a problem hiding this comment.
this PR (and this comment) is a duplicate of #102
|
@piotrbelina can we close it as a duplicate of #102? |
|
@kubawerlos please merge just any pull request just update the project to symfony 5 |
|
@piotrbelina if I could :( I've started reviewing this, so maybe this will @povils merge it faster. |
|
I think this PR is now duplicate because #105 is merged. Correct me if I'm wrong. |
Yes, it is a duplicate now. We can close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I updated composer.json to allow to use PHPMND in Symfony 5 projects
Cheers,
Piotr