-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ember CLI and PouchDB #186
Conversation
Thanks for doing this! The |
hmm, I restarted it again and it worked this time! The canary job is still failing with a similar error to the one the beta job had, but that’s an allowed failure, so ¯\_(ツ)_/¯ |
This is looking good! |
Travis is failing on a version number change in package.json and some readme change? It seems the new Perhaps rerun travis in a few hours? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, though I have some small remarks.
options.queryInverse = inverse.name; | ||
} | ||
} else { | ||
console.warn(type.modelName + " has a relationship with name " + rel.key + " that is many to many with type " + rel.type + ". This is not supported"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be preserved? Maybe with Ember.warn(msg, false)
@@ -0,0 +1,5 @@ | |||
{{!-- The following component displays Ember's default welcome message. --}} | |||
{{welcome-page}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file actually needed?
Would this even work without the ember-welcome-page package?
https://github.com/ember-cli/ember-addon-output/blob/master/tests/dummy/app/templates/application.hbs doesn't have this.
Upgrade project to ember-cli 2.14.1 and use pouchdb 6.3.4. Also updated tests to pass under eslint and use LTS versions of Ember CLI on travis.