Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember CLI and PouchDB #186

Merged
merged 3 commits into from
Jul 27, 2017
Merged

Conversation

ntodd
Copy link
Contributor

@ntodd ntodd commented Jul 26, 2017

Upgrade project to ember-cli 2.14.1 and use pouchdb 6.3.4. Also updated tests to pass under eslint and use LTS versions of Ember CLI on travis.

@backspace
Copy link
Collaborator

Thanks for doing this! The ember-beta job is failing, seemingly unable to find components/ember-data#beta. I tried deleting the cache on Travis to no avail. I have to leave now but I can look at it again later if no one else has ideas.

@backspace
Copy link
Collaborator

hmm, I restarted it again and it worked this time! The canary job is still failing with a similar error to the one the beta job had, but that’s an allowed failure, so ¯\_(ツ)_/¯

@broerse
Copy link
Collaborator

broerse commented Jul 27, 2017

This is looking good!

@broerse broerse merged commit e4113dc into pouchdb-community:master Jul 27, 2017
@broerse
Copy link
Collaborator

broerse commented Jul 27, 2017

Travis is failing on a version number change in package.json and some readme change? It seems the new trusty is not so trusty https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming?utm_source=web&utm_medium=banner&&utm_campaign=trusty-default

Perhaps rerun travis in a few hours?

Copy link
Collaborator

@jlami jlami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, though I have some small remarks.

options.queryInverse = inverse.name;
}
} else {
console.warn(type.modelName + " has a relationship with name " + rel.key + " that is many to many with type " + rel.type + ". This is not supported");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be preserved? Maybe with Ember.warn(msg, false)

@@ -0,0 +1,5 @@
{{!-- The following component displays Ember's default welcome message. --}}
{{welcome-page}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file actually needed?
Would this even work without the ember-welcome-page package?
https://github.com/ember-cli/ember-addon-output/blob/master/tests/dummy/app/templates/application.hbs doesn't have this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants