Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ember-cli fixes and some minor changes #147

Merged
merged 1 commit into from
Oct 13, 2016

Conversation

Fed03
Copy link
Contributor

@Fed03 Fed03 commented Oct 12, 2016

I've updated the addon to the latest ember-cli version available and other minor changes.

This PR is preparatory to some structure changes (not API) I've in mind that could open to a plugin ecosystem. For example I'm developing an ember-simple-auth plugin that uses pouchdb-authentication and hooks into ember-pouch.

I thought to open this PR first to know your opinions and to prepare the ground without an excessive shock

@broerse
Copy link
Collaborator

broerse commented Oct 12, 2016

@broerse
Copy link
Collaborator

broerse commented Oct 13, 2016

It looks good. Perhaps git squash this in one commit?

Squashed commits:
[713bd13] ember try config
[11789d8] travis.ci phantomjs
[8418b68] Updated ember-cli
@Fed03
Copy link
Contributor Author

Fed03 commented Oct 13, 2016

@broerse squash done!
About the existing beta addon I took a look at it and seems pretty good. As a matter of fact, I'm working over it and will do a PR there as well.
Lemme know if you are interested in the structure changes and/or where to propose them

@broerse
Copy link
Collaborator

broerse commented Oct 13, 2016

Yes please improve the beta addon. I am interested in structure changes. I like to see the move to NPM only. See also #120

@broerse
Copy link
Collaborator

broerse commented Oct 13, 2016

@Fed03
Copy link
Contributor Author

Fed03 commented Oct 13, 2016

@broerse I kept the current bower deps cause I didn't want to change anything that "matters" in this PR; but, if you want, I'll update them.

I don't really thought to switch to npm only. I read that if we want to use npm module in ember we must use something like ember-browserify, but I'm not so sure there's the only way. For ex, ember-datamoved from bower to npm altough they basically rewritten it in an ember-addon way.
Maybe I could use something like rollup during the compilation time.
I don't know how to do it right now, think you could give me any suggestion? thnx

ps. maybe @nolanlawson or @fivetanley can help us on this matter

@broerse
Copy link
Collaborator

broerse commented Oct 13, 2016

@Fed03 I will merge it like this.

@broerse broerse merged commit 7ccd2ad into pouchdb-community:master Oct 13, 2016
@Fed03 Fed03 deleted the new-version branch October 18, 2016 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants