Replaced Object.hasOwnProperty usages with loadsh _.has for safe access

Author: Vishal Shingala

lib/30XUtils/inputValidation.js

@@ -36,7 +36,7 @@ module.exports = {
       };
     }
 
-    if (!spec.info.hasOwnProperty('$ref')) {
+    if (!_.has(spec.info, '$ref')) {
       if (_.isNil(_.get(spec, 'info.title'))) {
         return {
           result: false,

lib/31XUtils/inputValidation31X.js

@@ -31,7 +31,7 @@ module.exports = {
       };
     }
 
-    if (!spec.info.hasOwnProperty('$ref')) {
+    if (!_.has(spec.info, '$ref')) {
       if (_.isNil(_.get(spec, 'info.title'))) {
         return {
           result: false,

lib/31XUtils/schemaUtils31X.js

@@ -98,11 +98,11 @@ module.exports = {
    */
   fixExamplesByVersion(schema) {
     // This method could be removed when schema faker gets upgraded
-    const hasExamplesInRoot = schema.hasOwnProperty('examples'),
-      hasChildItems = schema.hasOwnProperty('type') &&
-        schema.hasOwnProperty('items'),
-      hasProperties = schema.hasOwnProperty('properties'),
-      typeIsAnArray = schema.hasOwnProperty('type') &&
+    const hasExamplesInRoot = _.has(schema, 'examples'),
+      hasChildItems = _.has(schema, 'type') &&
+      _.has(schema, 'items'),
+      hasProperties = _.has(schema, 'properties'),
+      typeIsAnArray = _.has(schema, 'type') &&
         Array.isArray(schema.type);
 
     if (hasExamplesInRoot && typeIsAnArray) {

lib/common/schemaUtilsCommon.js

@@ -170,6 +170,9 @@ function checkValueEqualsDefault(value, definedDefault) {
  * @returns {Boolean} the value is the representation of its type
  */
 function isTypeValue(value, schema) {
+  if (!_.isObject(schema)) {
+    return false;
+  }
   if (schema.hasOwnProperty('type') && schema.hasOwnProperty('default')) {
     const isDefault = checkValueEqualsDefault(value, schema.default);
     if (isDefault) {
@@ -194,7 +197,7 @@ function isTypeValue(value, schema) {
  * @returns {Boolean} the value is the representation of its type
  */
 function checkIsCorrectType(value, schema) {
-  if (schema.hasOwnProperty('type') &&
+  if (_.has(schema, 'type') &&
     typeof schemaTypeToJsValidator[schema.type] === 'function') {
     const isCorrectType = schemaTypeToJsValidator[schema.type](value);
     if (isCorrectType) {
@@ -272,10 +275,10 @@ module.exports = {
   },
 
   handleExclusiveMaximum: function(schema, max) {
-    max = schema.hasOwnProperty('maximum') ?
+    max = _.has(schema, 'maximum') ?
       schema.maximum :
       max;
-    if (schema.hasOwnProperty('exclusiveMaximum')) {
+    if (_.has(schema, 'exclusiveMaximum')) {
       if (typeof schema.exclusiveMaximum === 'boolean') {
         return schema.multipleOf ?
           max - schema.multipleOf :
@@ -291,10 +294,10 @@ module.exports = {
   },
 
   handleExclusiveMinimum: function(schema, min) {
-    min = schema.hasOwnProperty('minimum') ?
+    min = _.has(schema, 'minimum') ?
       schema.minimum :
       min;
-    if (schema.hasOwnProperty('exclusiveMinimum')) {
+    if (_.has(schema, 'exclusiveMinimum')) {
       if (typeof schema.exclusiveMinimum === 'boolean') {
         return schema.multipleOf ?
           min + schema.multipleOf :
@@ -349,7 +352,7 @@ module.exports = {
 
   getServersPathVars: function(servers) {
     return servers.reduce((acc, current) => {
-      const newVarNames = current.hasOwnProperty('variables') ?
+      const newVarNames = _.has(current, 'variables') ?
         Object.keys(current.variables).filter((varName) => {
           return !acc.includes(varName);
         }) :

lib/common/versionUtils.js

@@ -143,15 +143,15 @@ function getFileByFileNameSpecificVersion(data, specificationVersion) {
 function getFileWithVersion(data, specificationVersion) {
   let file;
 
-  if (data[0].hasOwnProperty('content')) {
+  if (_.has(data[0], 'content')) {
     if (specificationVersion) {
       file = getFileByContentSpecificationVersion(data, specificationVersion);
     }
     else {
       file = getFileByContent(data);
     }
   }
-  else if (data[0].hasOwnProperty('fileName')) {
+  else if (_.has(data[0], 'fileName')) {
     if (specificationVersion) {
       file = getFileByFileNameSpecificVersion(data, specificationVersion);
     }