Rewrite

[andyjansson]

Why?

The dependencies are poorly maintained and contains a lot of bugs. "Inhousing" the logic would allow us to better maintain the plugin and fix said bugs.

Internal changes

• Rewrote plugin to house all logic 🎉
• Updated dependencies
  • Major changes:
    • Upgraded to babel 7
    • Upgraded to ava 1.0.0-beta.8
• Updated targeted node versions in travis.yml

Outward-facing changes

• Changed: Updated postcss-selector-parser to version 5.0.0-rc.3
• Changed: Dropped reduce-css-calc as a dependency
• Fixed: Support constant() and env() (#42, #48)
• Fixed: Support custom properties with "calc" in its name (#50)
• Fixed: Remove unnecessary whitespace around * and / (cssnano#625)
• Fixed: Arithmetic bugs around subtraction (#49)
• Fixed: Handling of nested calc statements (reduce-css-calc#49)
• Fixed: Bugs regarding complex calculations (reduce-cs-calc#45)
• Fixed: 100% incorrectly being transformed to 1 (reduce-css-calc#44)
• Added: support for case-insensitive calc statements

[jonathantneal]

This looks beautifully written. I am 💯 for it. Not sure if anyone else needs to approve, but lemme ping @ai.

[ai]

@jonathantneal I gave @andyjansson access to this repo

[jonathantneal]

Great! @andyjansson, how can I help you?

[andyjansson]

This looks beautifully written. I am 💯 for it.

Glad you like it :)

how can I help you?

Well, it would be a great help if anyone were willing to give it a spin before it goes live.

[alexander-akait]

Great job!

[alexander-akait]

Just note, i i think will be great use snapshots for testing - easy write new tests, better reading, fast writing

[jonathantneal]

@andyjansson,

(node:70308) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

Is this related to the tests + my version of node, or a third-party package issue, or something else?

[jonathantneal]

Could we use postcss-values-parser? I’m trying to get folks to stick with one. AFAIK, it is more frequently updated and respects original whitespace intents better. It is not perfect either, though, so I would not be entirely opposed to sticking with postcss-value-parser.

[andyjansson]

¯\_(ツ)_/¯

I don't really use the parsing for anything else than picking out the calc function. The rest of the parsing is handled internally.

[andyjansson]

I'd prefer not to switch to postss-values-parser as it offers no real way of extracting the function for further parsing. It only supplies a bunch of fragments.

[andyjansson]

Is this related to the tests + my version of node, or a third-party package issue, or something else?

I saw this, too. I believe it's an issue with yarn, actually. It triggers even if you do something trivial, like "hello": "echo hello". It is not present when executing it via npm.