Skip to content

Commit 493037e

Browse files
committed
normalize to display using swtich-to-buffer and recenter
Signed-off-by: Psionik K <73710933+psionic-k@users.noreply.github.com>
1 parent 47dff83 commit 493037e

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

lisp/erk.el

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,8 @@ what to do with it (yet). Returns `(def . name)' form."
385385
(after ")))"))
386386
(insert before)
387387
(save-excursion
388-
(insert after))))
388+
(insert after))
389+
(recenter)))
389390

390391
(defun erk--make-test-symbol (symbol)
391392
"Convert defun SYMBOL into test symbol."
@@ -417,8 +418,9 @@ corresponding `defun' are supported."
417418
(progn (erk-reload-project-tests)
418419
(when (ert-test-boundp test-name) test-name)))))
419420
(if test
420-
(progn (ert-find-test-other-window test)
421-
(forward-sexp))
421+
(progn (find-function-do-it test 'ert--test 'switch-to-buffer)
422+
(forward-sexp)
423+
(recenter))
422424
(let ((test-buffer (erk-jump-features)))
423425
(when (y-or-n-p (format "%s not found. Create? "
424426
test-name))
@@ -431,7 +433,8 @@ corresponding `defun' are supported."
431433
(if def
432434
(progn
433435
(find-function-do-it def nil 'switch-to-buffer)
434-
(forward-sexp))
436+
(forward-sexp)
437+
(recenter))
435438
(progn (erk-jump-features)
436439
(user-error "Definition not found: %s" def-name)))))
437440
(_

test/erk-test.el

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,17 @@
112112
(erk-jump-features)
113113
(string-match-p "lisp" default-directory))))
114114

115+
(ert-deftest erk-jump-defs-test ()
116+
(should
117+
(save-window-excursion
118+
(find-file (concat (erk--project-elisp-dir)
119+
"/erk.el"))
120+
(save-excursion
121+
(goto-char (point-min))
122+
(search-forward "(defun erk-jump-defs")
123+
(erk-jump-defs)
124+
(string-match-p "erk-test.el" (buffer-file-name (current-buffer)))))))
125+
115126
(ert-deftest erk--project-elisp-dir-test ()
116127
(should (erk--project-elisp-dir)))
117128

0 commit comments

Comments
 (0)