Add verbose log level for filenames being bundled #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
reviewed
Oct 17, 2023
| @@ -135,7 +135,7 @@ def server_args(func): | |||
| type=click.Path(exists=True, file_okay=True, dir_okay=False), | |||
| help="The path to trusted TLS CA certificates.", | |||
| ) | |||
| @click.option("--verbose", "-v", is_flag=True, help="Print detailed messages.") | |||
| @click.option("--verbose", "-v", count=True, help="Enable verbose output. Use -vv for very verbose (debug) output.") | |||
tdstein
approved these changes
Oct 17, 2023
I thought about that, but it didn't feel like trace output? |
kgartland-rstudio
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new log level, and emits messages at that level for each file that is added to a bundle. The new level is used when
-vis present on the command line; use-vvfor full debug logging.Intent
Fixes #363
Type of Change
Approach
Introduced a custom log level
VERBOSEbetweenINFOandDEBUG, and configure log level appropriately based on the verbosity. Change verbosity from a bool/flag to a counter/int.Automated Tests
Our tests don't validate logged messages.
Directions for Reviewers
Deploy various content types (notebook, app/API, and manifest) with no verbosity,
-v, and-vv. With-v, and-vv, you should see messages logged at levelVERBOSEshowing the files added to the bundle.Checklist