Skip to content

fix voila extra files #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2023
Merged

fix voila extra files #383

merged 3 commits into from
Mar 24, 2023

Conversation

bcwu
Copy link
Contributor

@bcwu bcwu commented Mar 23, 2023

Intent

fixes #381

This bug likely appeared after refactoring deploy html.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

@bcwu bcwu force-pushed the bcwu-extrafiles-voila branch from 6c8501d to 1b31caa Compare March 23, 2023 21:41
Copy link
Contributor

@mmarchetti mmarchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and I appreciate the added unit test. Can you also add QA notes to the PR?

@kgartland-rstudio
Copy link
Contributor

Verified fixed:

  • deploy voila with extra file in root directory
  • deploy voila with extra file in subdirectory
  • deploy html with extra file in root directory
  • deploy html with extra file in subdirectory

Are there any other areas to test?

@bcwu
Copy link
Contributor Author

bcwu commented Mar 24, 2023

Are there any other areas to test?

  • multiple extra files
  • exception when any extra doesn't exist

@kgartland-rstudio
Copy link
Contributor

I've tested those scenarios as well.

If there are no other content types expected to be impacted, feel free to merge.

@bcwu bcwu merged commit 71bb885 into master Mar 24, 2023
@bcwu bcwu deleted the bcwu-extrafiles-voila branch March 24, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying extra files with voila mode fails
3 participants