remove redundant isinstance check for metadata & app_mode

posit-dev · Apr 19, 2023 · 99f9ac4 · 99f9ac4
1 parent c574091
commit 99f9ac4
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/rsconnect/bundle.py b/rsconnect/bundle.py
@@ -79,16 +79,14 @@ def __init__(
         if environment:
             self.data["locale"] = environment.locale
 
-        if metadata and isinstance(metadata, dict):
-            self.data["metadata"] = metadata
-        elif metadata and not isinstance(metadata, dict):
-            raise TypeError("metadata must be a dictionary.")
-        else:
+        if metadata is None:
             self.data["metadata"] = {}
-            if isinstance(app_mode, AppMode):
-                self.data["metadata"]["appmode"] = app_mode.name()
-            else:
+            if app_mode is None:
                 self.data["metadata"]["appmode"] = AppModes.UNKNOWN
+            else:
+                self.data["metadata"]["appmode"] = app_mode.name()
+        else:
+            self.data["metadata"] = metadata
 
         if primary_html:
             self.data["metadata"]["primary_html"] = primary_html