Skip to content

Commit 11a6bf4

Browse files
authored
Merge pull request #216 from rstudio/revert-212-kegs-content-subcommands
Revert "Add rsconnect content api subcommands"
2 parents 0b2bf58 + 2e27b34 commit 11a6bf4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+470
-2659
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
matrix:
1212
# TODO: work on windows-latest compatibility?
1313
os: [ubuntu-latest]
14-
python-version: ['3.5', '3.6', '3.7', '3.8', '3.9']
14+
python-version: ['2.7', '3.5', '3.6', '3.7', '3.8', '3.9']
1515
include:
1616
- os: macos-latest
1717
python-version: '3.9'
@@ -25,9 +25,9 @@ jobs:
2525
python-version: ${{ matrix.python-version }}
2626
- run: pip install -r requirements.txt
2727
- run: pip freeze
28-
- if: matrix.python-version != '3.5'
28+
- if: matrix.python-version != '2.7' && matrix.python-version != '3.5'
2929
run: make fmt
30-
- if: matrix.python-version != '3.5'
30+
- if: matrix.python-version != '2.7' && matrix.python-version != '3.5'
3131
run: make lint
3232
- run: python setup.py --version
3333
- run: make test-${{ matrix.python-version }}
@@ -45,7 +45,7 @@ jobs:
4545
- run: make fmt
4646
- run: make lint
4747
- run: python setup.py --version
48-
- run: make mock-test-3.8
48+
- run: make test
4949
distributions:
5050
needs: test
5151
runs-on: ubuntu-latest

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,3 @@ htmlcov
2020
/tests/testdata/**/rsconnect-python/
2121
/docs/docs/index.md
2222
/docs/docs/changelog.md
23-
/rsconnect-build
24-
/rsconnect-build-test

CHANGELOG.md

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,6 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7-
## [1.7.0] - 2022-01-10
8-
9-
### Added
10-
11-
- Adds `rsconnect content` subcommands for interacting with RStudio Connect's `/v1/content`
12-
REST API. This allows users to search, download, and (re)build content. Users should
13-
note that the `rsconnect content build` subcommand requires RStudio Connect release 2021.11.1
14-
or later.
15-
16-
### Changed
17-
18-
- Support for Python 2.7 has been removed in this release.
19-
207
## [1.6.0] - 2021-08-30
218

229
### Added
@@ -45,7 +32,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
4532
rsconnect-python does not inspect the file contents to identify the object name, which must be
4633
one of the default names that Connect expects (`app`, `application`, `create_app`, or `make_app`).
4734

48-
- Ability to hide code cells when rendering Jupyter notebooks.
35+
- Ability to hide code cells when rendering Jupyter notebooks.
4936

5037
After setting up Connect (>=1.9.0) and rsconnect-python, the user can render a Jupyter notebook without its corresponding code cells by passing the ' hide-all-input' flag through the rsconnect cli:
5138

Makefile

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,16 @@ endif
2626
ifneq ($(CONNECT_API_KEY),)
2727
TEST_ENV += CONNECT_API_KEY=$(CONNECT_API_KEY)
2828
endif
29-
ifneq ($(CONNECT_CONTENT_BUILD_DIR),)
30-
TEST_ENV += CONNECT_CONTENT_BUILD_DIR=$(CONNECT_CONTENT_BUILD_DIR)
31-
endif
3229

3330
# NOTE: See the `dist` target for why this exists.
3431
SOURCE_DATE_EPOCH := $(shell date +%s)
3532
export SOURCE_DATE_EPOCH
3633

3734
.PHONY: all-tests
38-
all-tests: all-images test-3.5 test-3.6 test-3.7 test-3.8 test-3.9 test-3.10
35+
all-tests: all-images test-2.7 test-3.5 test-3.6 test-3.7 test-3.8
3936

4037
.PHONY: all-images
41-
all-images: image-3.5 image-3.6 image-3.7 image-3.8 image-3.9 image-3.10
38+
all-images: image-2.7 image-3.5 image-3.6 image-3.7 image-3.8
4239

4340
image-%:
4441
docker build -t rsconnect-python:$* --build-arg BASE_IMAGE=python:$*-slim .
@@ -52,16 +49,15 @@ test-%:
5249
mock-test-%: clean-stores
5350
@$(MAKE) -C mock_connect image up
5451
@sleep 1
55-
trap "$(MAKE) -C mock_connect down" EXIT; \
56-
CONNECT_CONTENT_BUILD_DIR="rsconnect-build-test" \
57-
CONNECT_SERVER="http://$(HOSTNAME):3939" \
58-
CONNECT_API_KEY="0123456789abcdef0123456789abcdef" \
59-
$(MAKE) test-$*
52+
CONNECT_SERVER=http://$(HOSTNAME):3939 CONNECT_API_KEY=0123456789abcdef0123456789abcdef $(MAKE) test-$*
6053
@$(MAKE) -C mock_connect down
6154

6255
fmt-%:
6356
$(RUNNER) 'black .'
6457

58+
.PHONY: fmt-2.7
59+
fmt-2.7: .fmt-unsupported
60+
6561
.PHONY: fmt-3.5
6662
fmt-3.5: .fmt-unsupported
6763

@@ -82,6 +78,9 @@ lint-%:
8278
$(RUNNER) 'flake8 rsconnect/'
8379
$(RUNNER) 'mypy -p rsconnect'
8480

81+
.PHONY: lint-2.7
82+
lint-2.7: .lint-unsupported
83+
8584
.PHONY: lint-3.5
8685
lint-3.5: .lint-unsupported
8786

0 commit comments

Comments
 (0)