Skip to content

fix: No longer need to manually calls session$ns() with shinychat #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

fix: No longer need to manually calls session$ns() with shinychat #10

merged 3 commits into from
Jun 3, 2025

Conversation

gadenbuie
Copy link
Contributor

With the latest version of shinychat (will be v0.2.0 release), chat_append_message() and friends handle namespacing in modules

@gadenbuie gadenbuie requested a review from jcheng5 May 15, 2025 17:30
schloerke
schloerke reviewed Jun 3, 2025
View reviewed changes
@schloerke schloerke changed the base branch from main to dev June 3, 2025 17:32
@schloerke schloerke merged commit c0e2180 into dev Jun 3, 2025
16 checks passed
@schloerke schloerke deleted the r/feat/no-ns-needed branch June 3, 2025 17:33
schloerke added a commit that referenced this pull request Jun 5, 2025
@schloerke
Merge branch 'dev' into restructure-folders
6e98ff6 
* dev:
  feat: genericizing data source using DataSource protocol: Supports SQLAlchemy and Pandas
  fix: No longer need to manually calls `session$ns()` with shinychat (#10)
  Remove website routine, no pkgdown site intended (#18)
chendaniely pushed a commit that referenced this pull request Jun 6, 2025
@gadenbuie @chendaniely
fix: No longer need to manually calls session$ns() with shinychat (#10
a571e7b 
)
@chendaniely chendaniely restored the r/feat/no-ns-needed branch June 6, 2025 22:20
chendaniely added a commit that referenced this pull request Jun 7, 2025
@chendaniely @gadenbuie @schloerke
fix: No longer need to manually calls session$ns() with shinychat (#10 …
444ce1d 
…#27)

This is a re-submission of #10 because the R version is currently broken without it.

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Barret Schloerke <barret@posit.co>
@chendaniely chendaniely deleted the r/feat/no-ns-needed branch June 7, 2025 03:05
@npelikan npelikan mentioned this pull request Jun 7, 2025
Merged
schloerke added a commit that referenced this pull request Jun 10, 2025
@schloerke
Merge branch 'dev' (#20)
c1297db 
* dev:
  chore!: Restructure folders to align with posit-dev/shinychat (#24)
  feat: genericizing data source using DataSource protocol: Supports SQLAlchemy and Pandas
  fix: No longer need to manually calls `session$ns()` with shinychat (#10)
  Remove website routine, no pkgdown site intended (#18)
@chendaniely chendaniely mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke left review comments

@jcheng5 jcheng5 Awaiting requested review from jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadenbuie @schloerke