Review changes

Author: timtmok

src/vs/workbench/contrib/positronPlots/browser/positronPlotsActions.ts

@@ -213,7 +213,7 @@ export class PlotsEditorAction extends Action2 {
 	constructor() {
 		super({
 			id: PlotsEditorAction.ID,
-			title: localize2('positronPlots.openEditor', 'Open Plot in Editor'),
+			title: localize2('positronPlots.openEditor', 'Open Plot in Editor tab'),
 			category,
 			f1: true,
 			precondition: ContextKeyExpr.equals(`config.${POSITRON_EDITOR_PLOTS}`, true),

src/vs/workbench/contrib/positronPlotsEditor/browser/editorPlotsContainer.tsx

@@ -7,7 +7,6 @@ import * as React from 'react';
 import { DynamicPlotInstance } from 'vs/workbench/contrib/positronPlots/browser/components/dynamicPlotInstance';
 import { StaticPlotInstance } from 'vs/workbench/contrib/positronPlots/browser/components/staticPlotInstance';
 import { ZoomLevel } from 'vs/workbench/contrib/positronPlots/browser/components/zoomPlotMenuButton';
-import { usePositronPlotsContext } from 'vs/workbench/contrib/positronPlots/browser/positronPlotsContext';
 import { PlotClientInstance } from 'vs/workbench/services/languageRuntime/common/languageRuntimePlotClient';
 import { IPositronPlotClient } from 'vs/workbench/services/positronPlots/common/positronPlots';
 import { StaticPlotClient } from 'vs/workbench/services/positronPlots/common/staticPlotClient';
@@ -19,8 +18,7 @@ interface EditorPlotsContainerProps {
 }
 
 export const EditorPlotsContainer = (props: EditorPlotsContainerProps) => {
-	usePositronPlotsContext();
-	const render = (plotClient?: IPositronPlotClient) => {
+	const render = (plotClient: IPositronPlotClient) => {
 		if (plotClient instanceof PlotClientInstance) {
 			return <DynamicPlotInstance
 				key={props.plotClient.id}

src/vs/workbench/contrib/positronPlotsEditor/browser/positronPlotsEditor.contribution.ts

@@ -25,17 +25,17 @@ class PositronPlotsEditorContribution extends Disposable {
 	static readonly ID = 'workbench.contrib.positronPlotsEditor';
 
 	constructor(
-		@IEditorResolverService _editorResolverService: IEditorResolverService,
-		@IInstantiationService _instantiationService: IInstantiationService
+		@IEditorResolverService editorResolverService: IEditorResolverService,
+		@IInstantiationService instantiationService: IInstantiationService
 	) {
 		super();
 
 		// Register the editor
-		this._register(_editorResolverService.registerEditor(
+		this._register(editorResolverService.registerEditor(
 			`${Schemas.positronPlotsEditor}:**/**`,
 			{
 				id: PositronPlotsEditorInput.EditorID,
-				label: localize('positronPlotsEditor', 'Plots Editor'),
+				label: localize('positronPlotsEditor', 'Editor Plot tab'),
 				priority: RegisteredEditorPriority.builtin
 			},
 			{
@@ -45,7 +45,7 @@ class PositronPlotsEditorContribution extends Disposable {
 			{
 				createEditorInput: ({ resource, options }) => {
 					return {
-						editor: _instantiationService.createInstance(
+						editor: instantiationService.createInstance(
 							PositronPlotsEditorInput,
 							resource
 						),
@@ -65,7 +65,7 @@ Registry.as<IEditorPaneRegistry>(EditorExtensions.EditorPane).registerEditorPane
 	EditorPaneDescriptor.create(
 		PositronPlotsEditor,
 		PositronPlotsEditorInput.EditorID,
-		'Plots Editor',
+		'Editor Plot tab',
 	),
 	[
 		new SyncDescriptor(PositronPlotsEditorInput)

src/vs/workbench/contrib/positronPlotsEditor/browser/positronPlotsEditor.tsx

@@ -168,13 +168,6 @@ export class PositronPlotsEditor extends EditorPane implements IPositronPlotsEdi
 		return null;
 	};
 
-	renderPlot = (plotClient: IPositronPlotClient) => {
-		if (plotClient instanceof PlotClientInstance) {
-			const dynamicPlot = plotClient as PlotClientInstance;
-			dynamicPlot.render(this._height, this._width, 1);
-		}
-	};
-
 	override async setInput(
 		input: PositronPlotsEditorInput,
 		options: IPositronPlotsEditorOptions,
@@ -188,7 +181,6 @@ export class PositronPlotsEditor extends EditorPane implements IPositronPlotsEdi
 
 		input.setName(plotClient.id);
 
-		// this.renderPlot(plotClient);
 		this.renderContainer(plotClient);
 		this.onSizeChanged((event: ISize) => {
 			this._height = event.height;

src/vs/workbench/contrib/positronPlotsEditor/browser/positronPlotsEditorInput.ts

@@ -17,7 +17,6 @@ export class PositronPlotsEditorInput extends EditorInput {
 
 	constructor(
 		readonly resource: URI,
-		// @IPositronPlotsService private readonly _positronPlotsService: IPositronPlotsService
 	) { super(); }
 
 	override dispose(): void {