Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't verify all checks #8

Closed
OneCyrus opened this issue Jul 27, 2023 · 3 comments · Fixed by #12
Closed

doesn't verify all checks #8

OneCyrus opened this issue Jul 27, 2023 · 3 comments · Fixed by #12

Comments

@OneCyrus
Copy link
Contributor

looks like this action only verifies the first 30 checks which are returned by default. Currently we have about 120 checks in a monorepo (most checks are skipped) so the action succeeds even when other checks are still running.

image

https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-for-a-git-reference

@dghubble
Copy link
Member

Wanna make a PR? I'm not likely to fix it unless it affects my use cases which are smaller

@dghubble
Copy link
Member

In v0.2.0, it gets up to 100 check runs

@OneCyrus
Copy link
Contributor Author

with PR #12 we fetch additional pages when not all are retrieved in the first request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants