Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Numbers in mad-readonly-form-field are now formatted automatically #46

Closed
Laess3r opened this issue Dec 17, 2020 · 0 comments · Fixed by #47
Closed

bug: Numbers in mad-readonly-form-field are now formatted automatically #46

Laess3r opened this issue Dec 17, 2020 · 0 comments · Fixed by #47
Assignees
@Laess3r
Labels
bug Something isn't working

Comments

@Laess3r
Copy link
Member

Laess3r commented Dec 17, 2020 •
edited
Loading

Bug Report

Since end of September the default behavior of mad-readonly-form-field (and mad-readonly-form-field-wrapper) has changed. Numbers are now formatted per default.

Expected Behavior

Not to format numbers per default, as before.

Current Behavior

Numbers are formatted, no option to disable this.

Possible Solution

Add an additional @input to explicitly enable number conversion, eg

@Input('formatNumber') formatNumber = false;

This is required in both mad-readonly-form-field and mad-readonly-form-field-wrapper
@Laess3r Laess3r added the bug Something isn't working label Dec 17, 2020
@Laess3r Laess3r changed the title bug: Behavior change. bug: Behavior change in mat-readonly-form-field Dec 17, 2020
@Laess3r Laess3r self-assigned this Dec 17, 2020
@Laess3r Laess3r changed the title bug: Behavior change in mat-readonly-form-field bug: Numbers in mad-readonly-form-field are now formatted automatically Dec 17, 2020
@Laess3r Laess3r mentioned this issue Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Laess3r Laess3r

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue-46: Fixed default formatting of readOnly form field porscheinformatik/material-addons
1 participant
@Laess3r