Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zerox~ #298

Open
porres opened this issue Mar 18, 2017 · 2 comments
Open

zerox~ #298

porres opened this issue Mar 18, 2017 · 2 comments
Labels

Comments

@porres
Copy link
Owner

porres commented Mar 18, 2017

frequency estimate is bad... block shouldn't affetct count?

@derekxkwan
Copy link
Contributor

looks like it only counts positive to negative or negative to positive (meaning > 0 to = 0 and =0 to > 0 aren't counted but < 0 to = 0 and = 0 to < 0 are). I suppose this is fine for most signals, but signals strictly >= 0 (such as [phasor~] but NOT [phasor~] * -1) would register as 0 frequency. I suppose this could be technically correct(?) since these signals don't cross zero, but it depends on what Max does. Also, this goes by block (which seems to be what Max does as well according to the documentation) so that could be another explanation for poor frequency estimate (which zero crossing isn't that great for anyways...)

@porres
Copy link
Owner Author

porres commented Feb 6, 2019

I suppose this could be technically correct(?)

I think so. For what I remember, Max has a better estimation output, this is why I should have opened this issue, but I'll double check (not a high priority right now though).

@porres porres added the bug label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants