-
Notifications
You must be signed in to change notification settings - Fork 4
Fix types for vendored files #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d2b2144 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well after a quick test in one repo, but haven't tested exhaustively.
I really don't understand why, but
Which leads me to suspect that it is the wildcard export in lit-html that needs splitting into individual exports? Or is there a release of lit-html and lit-html-server planned also? |
@knuthaug so TypeScript is happy, but Rollup (or esbuild?) isn't? |
no, typescript isn't happy either.
gives
typescript@4.8.3 |
It seems that TypeScript 4.8 isn't yet able to resolve aliased
package.json#exports
entries (Node/dvlp/esbuild are able to). This fix autogenerates alias files to ensure that TypeScript is able to resolve the modules correctly.Fixes #10