kunit: unregister the device on error

walac · shuahkh · commit fabd480b721e · 2024-05-06T14:22:02.000-06:00
kunit_init_device() should unregister the device on bus register error, but mistakenly it tries to unregister the bus. Unregister the device instead of the bus. Signed-off-by: Wander Lairson Costa <wander@redhat.com> Fixes: d03c720 ("kunit: Add APIs for managing devices") Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
diff --git a/lib/kunit/device.c b/lib/kunit/device.c
@@ -51,7 +51,7 @@ int kunit_bus_init(void)
 
 	error = bus_register(&kunit_bus_type);
 	if (error)
-		bus_unregister(&kunit_bus_type);
+		root_device_unregister(kunit_bus_device);
 	return error;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ int kunit_bus_init(void)`
`51`	`51`
`52`	`52`	`error = bus_register(&kunit_bus_type);`
`53`	`53`	`if (error)`
`54`		`- bus_unregister(&kunit_bus_type);`
	`54`	`+ root_device_unregister(kunit_bus_device);`
`55`	`55`	`return error;`
`56`	`56`	`}`
`57`	`57`