Skip to content

Commit a1f95ae

Browse files
Huai-Yuan Liudliviu
authored andcommitted
drm/arm/malidp: fix a possible null pointer dereference
In malidp_mw_connector_reset, new memory is allocated with kzalloc, but no check is performed. In order to prevent null pointer dereferencing, ensure that mw_state is checked before calling __drm_atomic_helper_connector_reset. Fixes: 8cbc5ca ("drm: mali-dp: Add writeback connector") Signed-off-by: Huai-Yuan Liu <qq810974084@gmail.com> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240407063053.5481-1-qq810974084@gmail.com
1 parent 42118c5 commit a1f95ae

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/gpu/drm/arm/malidp_mw.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,10 @@ static void malidp_mw_connector_reset(struct drm_connector *connector)
7272
__drm_atomic_helper_connector_destroy_state(connector->state);
7373

7474
kfree(connector->state);
75-
__drm_atomic_helper_connector_reset(connector, &mw_state->base);
75+
connector->state = NULL;
76+
77+
if (mw_state)
78+
__drm_atomic_helper_connector_reset(connector, &mw_state->base);
7679
}
7780

7881
static enum drm_connector_status

0 commit comments

Comments
 (0)