Skip to content

Commit

Permalink
drm/arm/malidp: fix a possible null pointer dereference
Browse files Browse the repository at this point in the history
In malidp_mw_connector_reset, new memory is allocated with kzalloc, but
no check is performed. In order to prevent null pointer dereferencing,
ensure that mw_state is checked before calling
__drm_atomic_helper_connector_reset.

Fixes: 8cbc5ca ("drm: mali-dp: Add writeback connector")
Signed-off-by: Huai-Yuan Liu <qq810974084@gmail.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240407063053.5481-1-qq810974084@gmail.com
  • Loading branch information
Huai-Yuan Liu authored and dliviu committed Apr 12, 2024
1 parent 42118c5 commit a1f95ae
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/gpu/drm/arm/malidp_mw.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ static void malidp_mw_connector_reset(struct drm_connector *connector)
__drm_atomic_helper_connector_destroy_state(connector->state);

kfree(connector->state);
__drm_atomic_helper_connector_reset(connector, &mw_state->base);
connector->state = NULL;

if (mw_state)
__drm_atomic_helper_connector_reset(connector, &mw_state->base);
}

static enum drm_connector_status
Expand Down

0 comments on commit a1f95ae

Please sign in to comment.