crypto: hisilicon/qm - fix incorrect return value of hisi_qm_resume()

Weili Qian · gregkh · commit 8b2b88054961 · 2022-01-27T11:03:35.000+01:00
[ Upstream commit 3f9dd4c ] When hisi_qm_resume() returns 0, it indicates that the device has started successfully. If the device fails to start, hisi_qm_resume() needs to return the actual error code to the caller instead of 0. Fixes: d7ea533 ("crypto: hisilicon - add runtime PM ops") Signed-off-by: Weili Qian <qianweili@huawei.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
@@ -5986,7 +5986,7 @@ int hisi_qm_resume(struct device *dev)
 	if (ret)
 		pci_err(pdev, "failed to start qm(%d)\n", ret);
 
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(hisi_qm_resume);
 

Original file line number	Diff line number	Diff line change
`@@ -5986,7 +5986,7 @@ int hisi_qm_resume(struct device *dev)`
`5986`	`5986`	`if (ret)`
`5987`	`5987`	`pci_err(pdev, "failed to start qm(%d)\n", ret);`
`5988`	`5988`
`5989`		`- return 0;`
	`5989`	`+ return ret;`
`5990`	`5990`	`}`
`5991`	`5991`	`EXPORT_SYMBOL_GPL(hisi_qm_resume);`
`5992`	`5992`