Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mfa verified check to workflow engine. solved #26 #240

Closed
wants to merge 11 commits into from

Conversation

mrvahedi68
Copy link

@mrvahedi68 mrvahedi68 added the enhancement New feature or request label Nov 26, 2022
@mrvahedi68
Copy link
Author

I checked them and see Nextcloud has some changes in the actions. all current PRs failed on the same action. I checked the Nextcloud action and see the change in the executed command for this check. Then tested that command on my workspace and it passed. We must update our actions and run checks again. @navid-dada

@michielbdejong Can you update from Nextcloud?

@michielbdejong
Copy link
Member

See discussion about failing tests in pondersource/nextcloud-mfa-awareness#27

@michielbdejong
Copy link
Member

Cypress is also failing in https://github.com/nextcloud/server master branch, but in a different way.
In any case, we don't want to add this code into nextcloud/server, because of pondersource/nextcloud-mfa-awareness#27 right?

Copy link
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.
@navid-dada can you review as well?
In any case, you should open this as an upstream PR at https://github.com/nextcloud/server, right?

apps/workflowengine/lib/Check/MfaVerified.php Fixed Show resolved Hide resolved
apps/workflowengine/lib/Check/MfaVerified.php Outdated Show resolved Hide resolved
apps/workflowengine/lib/Check/MfaVerified.php Outdated Show resolved Hide resolved
apps/workflowengine/lib/Manager.php Show resolved Hide resolved
apps/workflowengine/src/components/Checks/file.js Outdated Show resolved Hide resolved
@michielbdejong
Copy link
Member

This PR was created on the wrong repo; I now moved it here: nextcloud#36045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants