-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mfa verified check to workflow engine. solved #26 #240
Conversation
I checked them and see Nextcloud has some changes in the actions. all current PRs failed on the same action. I checked the Nextcloud action and see the change in the executed command for this check. Then tested that command on my workspace and it passed. We must update our actions and run checks again. @navid-dada @michielbdejong Can you update from Nextcloud? |
See discussion about failing tests in pondersource/nextcloud-mfa-awareness#27 |
Cypress is also failing in https://github.com/nextcloud/server master branch, but in a different way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
@navid-dada can you review as well?
In any case, you should open this as an upstream PR at https://github.com/nextcloud/server, right?
This PR was created on the wrong repo; I now moved it here: nextcloud#36045 |
Solved this issue:
pondersource/nextcloud-mfa-awareness#26