Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git deps with implicit url do not work #174

Closed
seancorfield opened this issue Dec 27, 2021 · 3 comments
Closed

git deps with implicit url do not work #174

seancorfield opened this issue Dec 27, 2021 · 3 comments
Assignees
@tengstrand
Labels
bug Something isn't working

Comments

@seancorfield
Copy link
Contributor

seancorfield commented Dec 27, 2021 •
edited
Loading

Describe the bug
tools.deps.alpha supports git deps like io.github.seancorfield/deps-new {:git/sha "..."} (plus com.github.user/repo and a few others), but poly test does not. See https://github.com/clojure/tools.deps.alpha/blob/master/src/main/clojure/clojure/tools/deps/alpha/extensions/git.clj#L17-L33

To Reproduce
Steps to reproduce the behavior:

https://github.com/seancorfield/poly-issue-174

Expected behavior
The git deps should work, just like t.d.a.
@tengstrand tengstrand self-assigned this Jan 4, 2022
@tengstrand tengstrand added the bug Something isn't working label Jan 14, 2022
@tengstrand
Copy link
Collaborator

I have pushed a fix, so please have a look at the issue-174 branch @seancorfield.

@seancorfield
Copy link
Contributor Author

This seems to work as expected. Thank you!

@tengstrand
Copy link
Collaborator

Thanks for verifying this. Now it's merged to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tengstrand tengstrand

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seancorfield @tengstrand