Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowbridge Headers on Demand #365

Merged

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Jun 28, 2024

Upgrades Snowbridge to have a much more cost effective Ethereum light client. In the current light client in production, all Ethereum execution headers are stored, whether they contain a transfer message or not. This PR upgrades Snowbridge to not store execution headers at all, but provide the execution header proof alongside a message. Ethereum beacon headers are still stored, to track finalized headers and do ancestry proofs.

More details on the change on the original PR: paritytech/polkadot-sdk#3761

@claravanstaden claravanstaden changed the title Snowbridge Header on Demand Snowbridge Headers on Demand Jun 28, 2024
@claravanstaden
Copy link
Contributor Author

claravanstaden commented Jun 28, 2024

@acatangiu the CI wants me to update the AH Kusama spec version: https://github.com/polkadot-fellows/runtimes/actions/runs/9713954965/job/26811939881?pr=365 Not sure why because I didn't change anything in AH. The Snowbridge crates AH depends on was also not bumped.

Should the BH spec version be 1_002_008? I think the previous upgrade didn't touch BH to perhaps 1_002_007` would be better?

@claravanstaden claravanstaden marked this pull request as ready for review July 1, 2024 07:29
spec_version: 1_002_006,
spec_version: 1_002_008,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we massage the dependency bumps a bit we might get away without having to bump the AH spec versions, right @claravanstaden ?

I wouldn't release new AH runtime versions that bring nothing new

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, I'm wrong.

Even if this PR does not change anything for AHs, there have been other things merged in the meantime relevant to AHs.

So all good with bumping this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acatangiu thanks! I see CI is complaining about the Kusama relay version too: https://github.com/polkadot-fellows/runtimes/actions/runs/9740656775/job/26878232348?pr=365

I bumped both the Polkadot and Kusama relay versions: b2a0b26

Is that OK?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, all good 👍 we have changelog entries for them too I see

@claravanstaden
Copy link
Contributor Author

@acatangiu I removed the P<>K and Snowbridge unstuck migrations, since they ran successfully. Is that OK?

@claravanstaden
Copy link
Contributor Author

@acatangiu what is the process to update the benchmarks? I need to do that before we release. Can I run it manually?

@bkontur
Copy link
Contributor

bkontur commented Jul 1, 2024

@acatangiu what is the process to update the benchmarks? I need to do that before we release. Can I run it manually?

@claravanstaden

Actually, there is no process yet :), but there is some ongoing work on the bot or process #128 by @mordamax.

You can do it by yourself, here is a tutorial: https://github.com/polkadot-fellows/runtimes/blob/main/docs/weight-generation.md and you need just some machine/VM aligned with reference hardware.

I did the last couple of weights regeneration on my dedicated machine, so I can also do it for you here, just let me know which pallets do you need and I can create PR to this PR.

@claravanstaden
Copy link
Contributor Author

@bkontur thank you for the tips! I would appreciate you helping out since I don't have the required hardware ready off-hand.

I need new weights for these two pallets:

  • snowbridge_pallet_ethereum_client
  • snowbridge_pallet_inbound_queue

Thanks again! <3

@bkontur
Copy link
Contributor

bkontur commented Jul 1, 2024

@bkontur thank you for the tips! I would appreciate you helping out since I don't have the required hardware ready off-hand.

I need new weights for these two pallets:

* snowbridge_pallet_ethereum_client

* snowbridge_pallet_inbound_queue

Thanks again! <3

please, check: Snowfork#13

Copy link

github-actions bot commented Jul 3, 2024

Review required! Latest push from author must always be reviewed

1 similar comment
Copy link

github-actions bot commented Jul 3, 2024

Review required! Latest push from author must always be reviewed

@claravanstaden
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 78c4600 into polkadot-fellows:main Jul 3, 2024
45 of 46 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@claravanstaden claravanstaden deleted the ethereum-headers-on-demand branch July 3, 2024 12:35
@claravanstaden claravanstaden mentioned this pull request Jul 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants