Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Weight V2 (with storage size) #881

Closed
nanocryk opened this issue Oct 21, 2022 · 2 comments
Closed

Support for Weight V2 (with storage size) #881

nanocryk opened this issue Oct 21, 2022 · 2 comments
Labels

Comments

@nanocryk
Copy link
Contributor

Question

What is the plan to support storage size introduced in paritytech/substrate#12277 ?

I don't see a way to estimate in advance the size limit or have a size limit in users' transactions. Could a collator try to execute Ethereum transactions with a size hint as the remaining size available in the block, and with a modified gasometer the EVM could panic of the storage size goes above the limit to prevent the transaction being included in the block?

@crystalin
Copy link
Contributor

@sorpaas, @nanocryk is coming with some ideas to support it. For now it seems it doesn't require much logic as it is kind of disabled, but we will need to come up with a strategy for it. Probably updating the gasometer to include some computation for it.

We also discussed some improvements that need to be done for GETCODESIZE and GETCODEHASH which are currently reading the code from storage (big PoV) and need to be moved to their own storage.

What's your opinion?

@nanocryk
Copy link
Contributor Author

nanocryk commented Nov 7, 2022

PR for code size/hash: #893

@sorpaas sorpaas closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants