Add the structures for the debugger #5
Conversation
polaroi8d
changed the title
| uint16_t count; /**< line count */ | ||
| } package; | ||
|
|
||
| #endif /* JERRY_DEBUG_H */ |
| @@ -0,0 +1,39 @@ | |||
| /* Copyright 2016 University of Szeged. | |||
There was a problem hiding this comment.
The file name should be jerry-debug.h
| */ | ||
|
|
||
| #ifndef JERRY_DEBUGGER_H | ||
| #define JERRY_DEBUGGER_H |
| char msg[128]; /**< the literal array */ | ||
| uint32_t line_offset; /**< line offset */ | ||
| uint32_t line_index; /**< line index */ | ||
| uint16_t count; /**< line count */ |
There was a problem hiding this comment.
There should not be packed everything into one structure. The layout should look like this (without comments):
typdef struct
{
uint8_t type;
uint8_t size;
} jerry_debug_message_header;
And each message should have its own type.
typdef struct
{
jerry_debug_message_header header;
char file_name[1];
} jerry_debug_message_source_name;
One structure for each message.
Perhaps SOURCE_FILE type is enough for this patch.
|
|
||
| typedef struct | ||
| { | ||
| package_type_t type; /**< type of the package */ |
There was a problem hiding this comment.
We never use types with unspecified length for network messages because the compiler might use types for them.
polaroi8d
force-pushed
the
header-debug
branch
from
242caf7 to
9e7c685
Compare
|
Updated the PR. |
| typdef struct | ||
| { | ||
| jerry_debug_message_header header; /**< header of the source file name struct */ | ||
| char file_name[128]; /**< the message */ |
There was a problem hiding this comment.
The file name should be 1 character long, and the real name should adapt the size
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu
polaroi8d
force-pushed
the
header-debug
branch
from
eca7048 to
b3b80dd
Compare
| typdef struct | ||
| { | ||
| jerry_debug_message_header header; /**< header of the source file name struct */ | ||
| char file_name[1]; /**< the message */ |
There was a problem hiding this comment.
This is definetely wrong. This means 1 character long string.
There was a problem hiding this comment.
No, this is correct.
This struct is a mapping struct, mapped to a buffer, and the maximum buffer size limits the file_name.
|
LGTM |
Add the structures what the debugger will be use.
JerryScript-DCO-1.0-Signed-off-by: Levente Orban orbanl@inf.u-szeged.hu