Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise errors instead of panicking when sink_csv fails #17313

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

JamesCE2001
Copy link
Contributor

Resolves #17275

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.72%. Comparing base (d444b79) to head (abbda01).
Report is 11 commits behind head on main.

Files Patch % Lines
...olars-pipe/src/executors/sinks/output/file_sink.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17313   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files        1475     1475           
  Lines      193162   193238   +76     
  Branches     2751     2760    +9     
=======================================
+ Hits       155922   155985   +63     
- Misses      36732    36743   +11     
- Partials      508      510    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 changed the title fix(rust, python): Raise errors instead of panicking when sink_csv fails fix: Raise errors instead of panicking when sink_csv fails Jul 1, 2024
@ritchie46 ritchie46 merged commit 26f84cf into pola-rs:main Jul 1, 2024
27 checks passed
@ritchie46
Copy link
Member

Thanks!

@JamesCE2001 JamesCE2001 deleted the sink-exceptions branch July 1, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when streaming unsupported datatypes to CSV
2 participants