Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use split_at instead of double slice in chunk splits. #16856

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

ritchie46
Copy link
Member

Can add this to more splitting functionality.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 37.12871% with 127 lines in your changes missing coverage. Please review.

Project coverage is 81.33%. Comparing base (3fe4cfe) to head (707664a).

Files Patch % Lines
...ates/polars-core/src/chunked_array/ops/chunkops.rs 58.02% 34 Missing ⚠️
...tes/polars-core/src/series/implementations/null.rs 0.00% 17 Missing ⚠️
.../polars-core/src/series/implementations/decimal.rs 0.00% 10 Missing ⚠️
...polars-core/src/series/implementations/datetime.rs 0.00% 9 Missing ⚠️
.../polars-core/src/series/implementations/struct_.rs 0.00% 7 Missing ⚠️
...ars-core/src/series/implementations/categorical.rs 0.00% 6 Missing ⚠️
...polars-core/src/series/implementations/duration.rs 0.00% 6 Missing ⚠️
crates/polars-core/src/utils/mod.rs 50.00% 6 Missing ⚠️
...es/polars-core/src/series/implementations/array.rs 0.00% 4 Missing ⚠️
...s/polars-core/src/series/implementations/binary.rs 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16856      +/-   ##
==========================================
- Coverage   81.37%   81.33%   -0.05%     
==========================================
  Files        1425     1425              
  Lines      187669   187867     +198     
  Branches     2702     2702              
==========================================
+ Hits       152720   152794      +74     
- Misses      34453    34577     +124     
  Partials      496      496              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 0b0af39 into main Jun 10, 2024
22 checks passed
@ritchie46 ritchie46 deleted the split_at branch June 10, 2024 19:50
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants