Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.str methods silenty cast input #18468

Closed
2 tasks done
cmdlineluser opened this issue Aug 30, 2024 · 1 comment · Fixed by #18474
Closed
2 tasks done

.str methods silenty cast input #18468

cmdlineluser opened this issue Aug 30, 2024 · 1 comment · Fixed by #18474
Assignees
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars

Comments

@cmdlineluser
Copy link
Contributor

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

pl.select(pl.lit(1.5).str.replace("1", "2"))
# shape: (1, 1)
# ┌─────────┐
# │ literal │
# │ ---     │
# │ str     │
# ╞═════════╡
# │ 2.5     │
# └─────────┘

Log output

No response

Issue description

Originally .replace was mentioned in #18465

It seems certain .str methods cast their input instead of throwing an error.

pl.select(pl.date(2024, 1, 1).str.extract("(..)"))
# shape: (1, 1)
# ┌──────┐
# │ date │
# │ ---  │
# │ str  │
# ╞══════╡
# │ 19   │
# └──────┘

These all seem affected:

  • .str.concat
  • .str.contains
  • .str.ends_with
  • .str.extract
  • .str.find
  • .str.join
  • .str.replace
  • .str.replace_all
  • .str.starts_with

Expected behavior

Should raise an exception?

pl.select(pl.lit(1.5).str.to_uppercase())
# SchemaError: invalid series dtype: expected `String`, got `f64`

Installed versions

--------Version info---------
Polars:               1.6.0
Index type:           UInt32
Platform:             macOS-13.6.1-arm64-arm-64bit
Python:               3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
great_tables:         <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
nest_asyncio:         <not installed>
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.1
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
sqlalchemy:           <not installed>
torch:                <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@cmdlineluser cmdlineluser added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels Aug 30, 2024
@ritchie46
Copy link
Member

Yeap.. Will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants