-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose null_on_oob
on gather
.
#16842
Comments
Request: Have expr.get() default to null_on_oob=True. Most real world use cases would want null_on_oob=True. Always having to type that in becomes tedious. I know this breaks backwards compatibility but in this case it probably will not cause issues in preexisting code bases. |
It doesn't just break backwards compatibility it goes against the fail early, fail loudly principle. It would also be inconsistent with cast strict=True default. |
Using Right now because An alternative solution is to allow rolling aggregates to stop ahead of time instead of unwinding at the end. When I use |
I think the oob-ing on non-null indexes makes sense. The issue is with contexts like aggregations where you can get nulls. Example: I don't think raising OOB there makes sense. But that might be discussion for another ticket. Prio should be to at least get an opt out with |
Found a couple of other older issues which can probably be closed in favour of this: |
Description
Similar to other
get
andlist.gather
, but then onExpr/Series
.Ref #15240
The text was updated successfully, but these errors were encountered: