Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename π to selected_columns and σ to filters in logal graph dot? #16735

Open
raybellwaves opened this issue Jun 5, 2024 · 4 comments
Open
Labels
A-formatting Area: display/repr of Polars objects enhancement New feature or an improvement of an existing feature needs decision Awaiting decision by a maintainer

Comments

@raybellwaves
Copy link

Description

The first time I saw π and σ in a graph viz (dot) e.g. https://pola.rs/_astro/optimized.e46e3f3c_ZSiab5.svg I was confused as what they meant. In the text (https://pola.rs/posts/polars_birds_eye_view/) I understood the represent selected_columns and filters, respectively. I wonder for simplification of a new user if they should be renamed to the plain language terms? It looks like the text box is wider enough to contain the text. Apologies if i'm missing something in the meaning of the symbols if they are preferred. You are welcome to close this out if that is the case

Link

No response

@raybellwaves raybellwaves added the documentation Improvements or additions to documentation label Jun 5, 2024
@raybellwaves raybellwaves changed the title rename π to selected_cols and σ to filters in logal graph dot rename π to selected_columns and σ to filters in logal graph dot? Jun 5, 2024
@datenzauberai
Copy link
Contributor

datenzauberai commented Jun 5, 2024

These are the symbols from relational algebra, that is taught in many computer science courses on relational databases. See https://en.wikipedia.org/wiki/Projection_(relational_algebra) and https://en.wikipedia.org/wiki/Selection_(relational_algebra)

@raybellwaves
Copy link
Author

These are the symbols from relational algebra, that is taught in many computer science courses on relational databases. See https://en.wikipedia.org/wiki/Projection_(relational_algebra) and https://en.wikipedia.org/wiki/Selection_(relational_algebra)

Cool. Thanks for sharing

@stinodego
Copy link
Member

I do agree that human-readable is probably better than using pi/sigma. These didn't mean anything to me when I started using Polars. But as @datenzauberai pointed out, there is a good reason these symbols are being used.

@stinodego stinodego added A-formatting Area: display/repr of Polars objects enhancement New feature or an improvement of an existing feature needs decision Awaiting decision by a maintainer and removed documentation Improvements or additions to documentation labels Jun 5, 2024
@ritchie46
Copy link
Member

I want to keep the output concise in the graphs. Would be cool if we could add a legend though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-formatting Area: display/repr of Polars objects enhancement New feature or an improvement of an existing feature needs decision Awaiting decision by a maintainer
Projects
None yet
Development

No branches or pull requests

4 participants