Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reshape should return an Array column rather than a List column #14005

Closed
stinodego opened this issue Jan 26, 2024 · 1 comment · Fixed by #16825
Closed

reshape should return an Array column rather than a List column #14005

stinodego opened this issue Jan 26, 2024 · 1 comment · Fixed by #16825
Assignees
@stinodego
Labels
A-api Area: changes to the public API A-dtype-list/array Area: list/array data type accepted Ready for implementation breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature
Milestone
1.0.0

Comments

@stinodego
Copy link
Member

Description

It just makes sense, as we are guaranteed to have entries of the same size.
@stinodego stinodego added enhancement New feature or an improvement of an existing feature accepted Ready for implementation A-api Area: changes to the public API A-dtype-list/array Area: list/array data type breaking Change that breaks backwards compatibility labels Jan 26, 2024
@stinodego stinodego added this to the 1.0.0 milestone Jan 26, 2024
@reswqa
Copy link
Collaborator

reswqa commented Jan 26, 2024

Make sense. I'll be involved in this before we get ready to release 1.0.

@Julian-J-S Julian-J-S mentioned this issue Feb 6, 2024
Open
@stinodego stinodego assigned stinodego and unassigned ritchie46 Jun 8, 2024
@stinodego stinodego mentioned this issue Jun 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinodego stinodego

Labels
A-api Area: changes to the public API A-dtype-list/array Area: list/array data type accepted Ready for implementation breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature
Projects
Backlog
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

feat(python)!: Update reshape to return Array types instead of List types pola-rs/polars
3 participants
@ritchie46 @stinodego @reswqa