From 6a244ef04cd30b2bb6d3b375f8333a6668c46f31 Mon Sep 17 00:00:00 2001
From: Mick van Gelderen <mickvangelderen@gmail.com>
Date: Wed, 6 Mar 2024 14:13:53 +0100
Subject: [PATCH] feat(rust)!: Import `NamedFrom` in `df!` macro (#14860)

---
 crates/polars-core/src/utils/mod.rs        | 6 +++---
 crates/polars-io/src/cloud/adaptors.rs     | 2 +-
 crates/polars-sql/tests/ops_distinct_on.rs | 1 -
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/crates/polars-core/src/utils/mod.rs b/crates/polars-core/src/utils/mod.rs
index 19e9e68c38b4..1ccf29942bcc 100644
--- a/crates/polars-core/src/utils/mod.rs
+++ b/crates/polars-core/src/utils/mod.rs
@@ -538,9 +538,9 @@ macro_rules! apply_method_physical_numeric {
 #[macro_export]
 macro_rules! df {
     ($($col_name:expr => $slice:expr), + $(,)?) => {
-        {
-            $crate::prelude::DataFrame::new(vec![$($crate::prelude::Series::new($col_name, $slice),)+])
-        }
+        $crate::prelude::DataFrame::new(vec![
+            $(<$crate::prelude::Series as $crate::prelude::NamedFrom::<_, _>>::new($col_name, $slice),)+
+        ])
     }
 }
 
diff --git a/crates/polars-io/src/cloud/adaptors.rs b/crates/polars-io/src/cloud/adaptors.rs
index 0b290c275962..1d609591775f 100644
--- a/crates/polars-io/src/cloud/adaptors.rs
+++ b/crates/polars-io/src/cloud/adaptors.rs
@@ -226,7 +226,7 @@ impl Drop for CloudWriter {
 #[cfg(test)]
 mod tests {
     use polars_core::df;
-    use polars_core::prelude::{DataFrame, NamedFrom};
+    use polars_core::prelude::DataFrame;
 
     use super::*;
 
diff --git a/crates/polars-sql/tests/ops_distinct_on.rs b/crates/polars-sql/tests/ops_distinct_on.rs
index f502192d51cc..d9016b24a9b0 100644
--- a/crates/polars-sql/tests/ops_distinct_on.rs
+++ b/crates/polars-sql/tests/ops_distinct_on.rs
@@ -1,5 +1,4 @@
 use polars_core::df;
-use polars_core::prelude::*;
 use polars_lazy::prelude::*;
 use polars_sql::*;